-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix separate search results page #8707
Conversation
Hard-Coded Secrets (1)
More info on how to fix Hard-Coded Secrets in General. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
23d4c6e
to
2b116d9
Compare
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8707-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8707-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8707-documentation.appa.pantheon.site |
Styles for if/when number-of-results becomes an h2
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8707-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
The search results page is themed. I'm going to also theme the dropdown search results, but I'll do that in a separate PR so as to not hold this one up.
I'm not sure how much control you have over the markup from addsearch, but if possible the "number-of-results" should probably be an h2. Alternatively, the search hit titles could be h2 instead of h3. Either solution would work for proper heading levels on this page for accessibility purposes. I wouldn't hold up the whole thing for this, as it can always be fixed later, but I thought I'd mention it in case it was an easy change.
I'd prefer we handle that in a follow up. |
Also, thanks @mel-miller! I'm passing this along internally and hope to have it merged soon. |
replace #8665
The search field after the PDS Theme was implemented has a better experience than the (at the time) current production theme, so I switched efforts to this PR and I'm getting expected behaviors now on local and the preview env (in #8665 separate search results page worked locally but not on the preview)
Expected Search Experience:
/search
) and you hit enter, you are now directed to the separate search results page with the query passed in and results shown on page load/search
) the results should upate as you type, hitting enter in this search field on this page should not load a new page but it should update the search URL paramater in the address bar