Update modules-known-issues.md #8836
Conversation
There are no more known issues for the module: "Simple OAuth / OAuth 2.0 Issue: The module requires a very specific set of permissions for the folder and the keys to be uploaded. Using Private or non-standard filepaths won't work. It is not possible to change these in LIVE or TEST environment. Solution: You can try to patch the permission check in the module. The alternative is to use off-site key management tools like Lockr" The module now works without a workaround.
|
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8836-documentation.appa.pantheon.site |
|
@ryanshoover can you assign someone from your team to review? |
rachelwhitton
added
the
Process: Needs SME
rachelwhitton
removed
the
Process: Needs SME
|
this is still an issue and we should recommend the patches to oauth which been tested / validated by other Pantheon customers: https://github.com/lcatlett/oauth2-server/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc Patch links: |
|
@lcatlett are these patches something you expect to contribute upstream to the main project |
|
@rachelwhitton can you update this PR to tell customers that these patches are needed (and how to apply them)? |
|
@stevector done! reassigned this one to you for next steps |
|
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8836-documentation.appa.pantheon.site |
|
|
||
| **Solution**: Apply the following patches (which have been tested and validated by Pantheon), based on your site's PHP version, to solve for this issue: | ||
| * [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 8.0+)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/1.patch) | ||
| * [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch) |
There was a problem hiding this comment.
| * [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch) | |
| * [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/pantheon-systems/oauth2-server/pull/2.patch) |
There was a problem hiding this comment.
@stevector I think you might have duplicated the first PR twice by mistake?
https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch
vs
https://patch-diff.githubusercontent.com/raw/pantheon-systems/oauth2-server/pull/2.patch
There was a problem hiding this comment.
Ah gotcha, my mistake I'll go ahead and commit this suggestion but mark the convo unresolved and reassign to you for next steps (defer to you on whether we merge or proceed with additional tech review first)
|
@rachelwhitton can you review? |
Co-authored-by: Steve Persch <[email protected]>
|
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8836-documentation.appa.pantheon.site |
Co-authored-by: Steve Persch <[email protected]>
|
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-8836-documentation.appa.pantheon.site |
rachelwhitton
added
the
Process: Needs SME
There are no more known issues for the module:
"Simple OAuth / OAuth 2.0
Issue: The module requires a very specific set of permissions for the folder and the keys to be uploaded. Using Private or non-standard filepaths won't work. It is not possible to change these in LIVE or TEST environment.
Solution: You can try to patch the permission check in the module. The alternative is to use off-site key management tools like Lockr"
The module now works without a workaround.
Closes #
Summary
Doc Page Title - <Enter a one sentence summation of the pertinent changes (including not-yet-completed work) provided by this PR.>
Effect
The following changes are already committed:
Remaining Work and Prerequisites
The following changes still need to be completed:
Dependencies and Timing
Release:
Post Launch
Do not remove - To be completed by the docs team upon merge:
/old-path/=>/new-path/(if applicable)