-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSSH requirements to 02-install.md #9228
Conversation
Adding details about OpenSSH requirements for Terminus nested Drush and WP-CLI commands.
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9228-documentation.appa.pantheon.site |
@@ -66,6 +66,9 @@ Terminus does not work with the following platforms: | |||
|
|||
### Recommended Packages | |||
|
|||
- [OpenSSH 7.8](https://github.com/PowerShell/Win32-OpenSSH/wiki/) or later | |||
- You can check your OpenSSH version by running `ssh -V` from a terminal application. | |||
- This is required package for executing nested Drush or WP-CLI commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the copy says this package is required, it should be moved from "Recommended Packages" to the above section, "Required Packages". nvm it makes sense here after a second read
Should this also be added to the projects README?
@kporras07 @stovak can you review and weigh in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of calling openssh out here (and maybe even moving it to required); I'm not sure I like linking it to PowerShell Win32-OpenSSH but I don't know of a better link. Would it make sense to NOT link anything here and allow customers to get the right package based on their OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agreement on also getting it to project's README. I can create a quick PR once we figure out how we want to do it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kporras07 I reviewed this again with @jazzsequence during docs coworking this morning, we decided to remove the link entirely (we don't link out to PHP in that same list so I think it's fine without), move OpenSSH up to the required packages section, and remove the recommended packages section. Can you do another review when convenient?
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9228-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding details about OpenSSH requirements for Terminus nested Drush and WP-CLI commands.
Verified this information in https://pantheon.slack.com/archives/C1P99MH3M/p1726675141658079.
Summary
Doc Page Title - <Enter a one sentence summation of the pertinent changes (including not-yet-completed work) provided by this PR.>