Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGS-7554] Fix php 8.1 warning in Apache Solr module #201

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[BUGS-7554] Fix php 8.1 warning in Apache Solr module #201

merged 1 commit into from
Mar 8, 2024

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Mar 8, 2024

Starting PHP 8.1, we started seeing the following warning from trim():

Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in PantheonApacheSolrService->_makeHttpRequest() (line 500 of /code/modules/pantheon/pantheon_apachesolr/Pantheon_Apache_Solr_Service.php).

Here we now check that the array_shifted variable is not empty first.

@pwtyler pwtyler marked this pull request as ready for review March 8, 2024 20:25
@pwtyler pwtyler mentioned this pull request Mar 8, 2024
Merged
@pwtyler pwtyler merged commit d1eb2d8 into default Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwagner00 rwagner00 rwagner00 approved these changes

@greg-1-anderson greg-1-anderson Awaiting requested review from greg-1-anderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwtyler @rwagner00 @pantheon-ci-bot