Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Diffy visual regression testing integration #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ygerasimov
Copy link

Adds an integration with https://diffy.website. It was built with an example of BackstopJS integration (same changes/commit command triggers the job).

Also terminus command https://github.com/DiffyWebsite/diffy-build-tools-plugin is available to make it easier configure CircleCI.

@stevector
Copy link
Contributor

Hi @ygerasimov, thanks for showing that this is possible! But I'm reluctant to add this kind of feature to this example. Just yesterday I was chatting with co-workers in our internal Slack about my concern that the size and complexity of this repo makes it difficult for people to adopt if they're first just looking to adopt Composer and a PR workflow. Adding a second visual regression testing service when Backstop is already present is more complexity than benefit IMO.

@greg-1-anderson, I'm curious what you think here too. I'd prefer that Diffy was document as a potential integration, maybe through a CircleCI Orb, rather than something baked into this example repo.

@ygerasimov
Copy link
Author

@stevector I completely understand your concern. For sure having two visual regression services doesn't make sense.

I was thinking about a set up like you have in quicksilver examples https://github.com/pantheon-systems/quicksilver-examples, where you could have multiple solutions available for you. So it you simply pick an choose the ones you like.

As for Diffy, maybe I could comment out a diffy_visual_regression_testing workflow job in config.yml and provide instructions how to set it up. Then by default it won't be applicable, but still people could discover the possibility and use it easily if needed? What do you think?

@stevector
Copy link
Contributor

@ygerasimov, yeah, I'd be fine with with adding something like a heading of "Additional Testing Examples" to the readme of this project that could list integrations like Diffy. I think CircleCI Orbs are the best available mechanism for distributing examples like that.

I do not want to go the route of a commented-out example directly in config.yml because that file is currently 269 lines long which is already in the range to overwhelm a CI newcomer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants