[CMSP-150] Update network setup #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is what replaces the default wp core network page with our own
this indents the first line in the textarea which we don't want
since our instructions are much shorter in the future maybe we might want this to be filterable but I don't think we need it now
so we don't escape the html we're legitimately passing
pwtyler
approved these changes
Jun 4, 2024
Merged
4 tasks
al-esc
added a commit
to crowdfavorite/pantheon-mu-plugin
that referenced
this pull request
Jun 6, 2024
[CMSP-150] Update network setup (pantheon-systems#49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the network setup process by requiring the network setup file anytime allow multisite is true. Previously this was only included if MULTISITE was also true, but this prevents our network setup page (with the filters we've added) from displaying on the Network Setup page.
It also removes the tab before ob_start to fix the indentation in the textarea.
Additionally, it reduces the number of lines in the textarea and uses
wp_kses_postinstead ofesc_htmlto prevent escaping legitimate HTML.