Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE-372] allow subdirectory networks warning to be filtered #51

Merged

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Jul 19, 2024

This PR adds a new function that just returns a warning that appears on the Network Setup page in subdirectory multisite installs when the wp-content directory is modified (e.g. as it is in Bedrock). It then implements a filter to disable the warning that WordPress (Composer Managed) can consume (see pantheon-systems/wordpress-composer-managed#144).

A test has been added to validate the output of the new function both before and after the filter has been applied.

it's not actually standard in the source because WP is dumb and no one looks at this page.
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 on multiple asserts in the test case otherwise 👍🏻

tests/phpunit/test-network.php Outdated Show resolved Hide resolved
@jazzsequence jazzsequence merged commit b4dbc57 into main Jul 19, 2024
7 checks passed
@jazzsequence jazzsequence deleted the site-372-allow-subdirectory-networks-warning-to-be-filtered branch July 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants