Add PhastPress as an incompatible plugin #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new section for plugin_compatibility to use with incompatible plugins
pwtyler
reviewed
Aug 30, 2024
Co-authored-by: Phil Tyler <[email protected]>
pwtyler
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PhastPress plugin to the list of incompatible plugins (see docs page).
In addition to adding it to the items requireing review (which lists partially and incompatible plugins), it updates the main site health page to add any plugins that are incompatible on Pantheon to the critical issue section rather than listing them as recommended improvements only.
This is accomplished by adding a new boolean parameter to the
output_compatibility_status_tablefunction that allows a list of plugins to be passed (e.g. fromget_compatibility_manual_fixes/get_compatibility_review_fiexes) and specifically filter by anincompatiblevalue in a newplugin_compatibilityparameter that can be added to plugins when doing tests for the Site Health page.The update displays incompatible plugins alongside plugins that require manual fixes or other things listed as Critical issues.
Tests have been added for the
output_compatibility_status_tablefunction.Fixes #53
