Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility layer - Add manual fix required warning for WP Cerber #59

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Aug 30, 2024

WP Cerber's anti-bot-spam features make the site uncacheable.

This PR adds WP Cerber to the compatibility layer to flag as an issue on the site health status page.
Screenshot 2024-09-05 at 3 07 21 PM

Automatically fixing the issue was investigated but discarded when setting the apparent options in the database did not appear to resolve the issue.

This PR also adds a filter that allows the list of known incompatible plugins to be modified (e.g. if you know there's an issue and want to remove the warning from the Site Health page) and documentation for the filter.

Fixes #52

Partially blocked by pantheon-systems/documentation#9164 (we need the documentation to exist before this should be included in a release)

@jazzsequence jazzsequence requested a review from a team as a code owner August 30, 2024 21:30
@jazzsequence jazzsequence self-assigned this Aug 30, 2024
@jazzsequence jazzsequence changed the title Compatibility layer - Apply fix for WP Cerber to allow CDN caching Compatibility layer - Add manual fix required warning for WP Cerber to allow CDN caching Sep 5, 2024
@jazzsequence jazzsequence changed the title Compatibility layer - Add manual fix required warning for WP Cerber to allow CDN caching Compatibility layer - Add manual fix required warning for WP Cerber Sep 5, 2024
@jazzsequence jazzsequence requested a review from pwtyler September 6, 2024 15:29
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I would love to see the site-heath array DRYed up a bit, down to an array of unique values/types if, for example, the plugin message is going to be the same link with a different achor, or the plugin status is one of only a couple values.

@jazzsequence
Copy link
Contributor Author

@pwtyler I agree. As I dig into it more, I find places to improve things. I think we can just continue to make it better over time.

@jazzsequence jazzsequence merged commit c9f69cb into main Sep 6, 2024
10 checks passed
@jazzsequence jazzsequence deleted the compat/wp-cerber branch September 6, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WP Cerber to compatibility layer
2 participants