Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use New Relic's V2 API for marking deploys #157

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Use New Relic's V2 API for marking deploys #157

merged 2 commits into from
Mar 12, 2023

Conversation

sarahg
Copy link

@sarahg sarahg commented May 22, 2019

Closes #141 and #155

PR includes the following changes:

  • Use the New Relic v2 API (inspired largely by @pingevt in this issue comment).
  • Use PHP cURL so we can capture more debugging output and set timeouts.

@davidneedham
Copy link
Contributor

I just added this to a WordPress site and it worked flawlessly.

joeparsons
joeparsons suggested changes Jun 26, 2019
View reviewed changes
Copy link

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the fix that was merged in #145 be preserved?

@kyletaylored kyletaylored mentioned this pull request Oct 28, 2021
Open
philoSurfer
philoSurfer approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@philoSurfer philoSurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been waiting for approval for some time and V2 api needs to be supported in our examples moving forward.

@philoSurfer philoSurfer merged commit 894eead into pantheon-systems:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeparsons joeparsons joeparsons requested changes

@philoSurfer philoSurfer philoSurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Relic API v2
4 participants
@sarahg @davidneedham @joeparsons @philoSurfer