WIP: Experimental hack for DDev #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevector Thank you so much for this! I copied your changes into my local version of the module, and my local Solr is no longer reporting errors and can even index content. I also wanted to mention that DDEV with both Solr add-on versions (Solr 8 ddev-drupal-solr and cloud Solr ddev-solr) works with regular search_api_solr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some co-working today with @stovak and @jazzsequence trying to work out #181. We found that some requests from Drupal to Solr included the name of the core in the path of the request and some did not. (We did this by toggling
debugproperty here: https://github.com/pantheon-systems/search_api_pantheon/blob/8.x/src/Services/PantheonGuzzle.php#L63)Those that did not were 404s, those that did were 200s. So here's a hacky re-insertion of the core name that at least gets rid of the error in #181.
Someone with a better understanding of Solr than me could do more to explain. If I kept going, I'd stop comparing search_api_pantheon on a Pantheon multidev to search_api_pantheon on DDev and instead do a DDev to DDev comparison. I bet DDev works fine with regular search_api_solr.