Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jeli 93][SITE-2457] Reload core during post schema #192

Closed
wants to merge 15 commits into from
Closed

[Jeli 93][SITE-2457] Reload core during post schema #192

wants to merge 15 commits into from

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Nov 14, 2024

This replaces #189 following the release of #191 to the 8.1.x branch, to keep git conflicts to a minimum.

  • Reloads schema after schema is posted
  • Adds reload terminus command
  • calls new reload endpoint as part of reloadCore() instead of the no-op log.

@pwtyler
reload core during schema update (#191)
1453eac 
---------
Co-authored-by: Brian Weaver <[email protected]>
Co-authored-by: Kevin Porras <[email protected]>
Co-authored-by: Tom Stovall <[email protected]>
@pwtyler pwtyler mentioned this pull request Nov 14, 2024
Closed
@pwtyler
Merge branch '8.x' into 8.1.x
562b74b 
Reconciles commits to 8.x squashed into the last update
@pwtyler
Revert "restore reload_path"
b48e779 
This reverts commit f89aa7c.
@pwtyler
Revert "back out solr connector"
cb1f1d5 
This reverts commit 1714e95.
@stovak stovak marked this pull request as ready for review November 14, 2024 19:55
@stovak stovak requested a review from a team as a code owner November 14, 2024 19:55
kporras07
kporras07 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only a couple super small comments

src/Services/SchemaPoster.php Outdated Show resolved Hide resolved
src/Services/SchemaPoster.php Outdated Show resolved Hide resolved
@namespacebrian namespacebrian mentioned this pull request Nov 14, 2024
Merged
@stovak stovak closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishasahnipantheon manishasahnipantheon manishasahnipantheon approved these changes

@kporras07 kporras07 kporras07 approved these changes

@stovak stovak stovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pwtyler @stovak @kporras07 @manishasahnipantheon