[CMSP-628, CMSP-680] Update WordPress upstreams from commits [WIP, DNM] #118
Conversation
|
+1 on WPMS fixture tests. |
There was a problem hiding this comment.
I didn't really get into it line by line to give any more specific of a suggestion, but reading through projectUpstreamUpdate, I have the sense the old code checking the version numbers is made redundant by the fact that we're now just checking commits. That could likely just be dropped since the tags are made redundant by that ||. If the tags give us reason to update, so will the commit comparison.
* add wpms tests and fixture not sure if this will actually work, i guess we run it and find out... * add multisite tests * fix comments * force db drop * try to foce the db drop * try to force the db drop...again * remove the db drop * try dropping the db via exec * add a way to get the path from a config file * use the path to drop the wp database * add tmate for debugging * temporarily force tmate to run * we don't need the commented-out gh auth login * comment out the conditional * remove the conditional entirely * more tmate hacking * i give up on trying to get tmate to work, debug manually * try to drop the db a different way. * remove execute, update exec and exit early * maybe add some debugging * pull down a copy of the wpms repo * remove db drop and exit * attempt to pass force-db-drop * an array is definitely not it * reset to last working commit with only 1 failure & force db drop * is force-db-drop being passed? * add forceDbDrop property which checks the project config for force-db-drop * remove the var_dump
|
@pwtyler I'm seeing a lot of stuff that would still use the version checking stuff -- if for no other reason than for update notifications that are triggered by tags. If we removed all of it, I think we would break a lot of things. The change @rwagner00 made in 3679b2d are probably sufficient so we aren't requiring that to trigger updates. |
now that I've synced the histories up
even though I'm not sure what it does
since we removed main branch
this will tell us if the $current === $latest logic is failing
we shouldn't need it but i'm grasping
and remove debug code
jazzsequence
changed the title
jazzsequence
changed the title
Overview
This pull request:
Full writeup here: https://github.com/pantheon-systems/cms-platform/discussions/63
Resolves https://getpantheon.atlassian.net/browse/CMSP-628
Summary
Causes normal commits without tags to also trigger the update process.