Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSP-660] Update to use Pantheon-WP-Coding-Standards #111

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Conversation

jazzsequence
Copy link
Contributor

Merging is blocked until pantheon-systems/Pantheon-WP-Coding-Standards#4 is merged.

This switches the repository to use Pantheon-WP as the PHPCS ruleset, rather than PSR-2 from the original Roots config.

Uses WPCS 3.0, so should not be merged until the linked issue above is merged.

@guardrails
Copy link

guardrails bot commented Sep 11, 2023

⚠️ We detected 10 security issues in this pull request:

Hard-Coded Secrets (10)
Severity Details Docs
Medium Title: WP-Config
Config::define( 'DB_PASSWORD', env( 'DB_PASSWORD' ) );
📚
Medium Title: WP-Config
Config::define( 'DB_CHARSET', 'utf8mb4' );
📚
Medium Title: WP-Config
Config::define( 'AUTH_KEY', env( 'AUTH_KEY' ) );
📚
Medium Title: WP-Config
Config::define( 'SECURE_AUTH_KEY', env( 'SECURE_AUTH_KEY' ) );
📚
Medium Title: WP-Config
Config::define( 'LOGGED_IN_KEY', env( 'LOGGED_IN_KEY' ) );
📚
Medium Title: WP-Config
Config::define( 'NONCE_KEY', env( 'NONCE_KEY' ) );
📚
Medium Title: WP-Config
Config::define( 'AUTH_SALT', env( 'AUTH_SALT' ) );
📚
Medium Title: WP-Config
Config::define( 'SECURE_AUTH_SALT', env( 'SECURE_AUTH_SALT' ) );
📚
Medium Title: WP-Config
Config::define( 'LOGGED_IN_SALT', env( 'LOGGED_IN_SALT' ) );
📚
Medium Title: WP-Config
Config::define( 'NONCE_SALT', env( 'NONCE_SALT' ) );
📚

More info on how to fix Hard-Coded Secrets in PHP.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@jazzsequence jazzsequence marked this pull request as ready for review September 12, 2023 19:08
@jazzsequence jazzsequence requested review from a team as code owners September 12, 2023 19:08
@jazzsequence jazzsequence merged commit f75a64b into default Sep 14, 2023
3 checks passed
@jazzsequence jazzsequence deleted the cmsp-660 branch September 14, 2023 18:05
jazzsequence added a commit that referenced this pull request Jul 31, 2024
* update the lint:phpcs command

* use Pantheon WP as the base

* ignore the upstream configuration folder

* document the exclude rule for plugins

* carve out exclusions for config/application.php

* rename to Pantheon

* linting fixes

* exclude blacklisted iniset
jazzsequence added a commit that referenced this pull request Aug 1, 2024
* update the lint:phpcs command

* use Pantheon WP as the base

* ignore the upstream configuration folder

* document the exclude rule for plugins

* carve out exclusions for config/application.php

* rename to Pantheon

* linting fixes

* exclude blacklisted iniset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants