-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSP-660] Update to use Pantheon-WP-Coding-Standards #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-Coded Secrets (10)
More info on how to fix Hard-Coded Secrets in PHP. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
pwtyler
approved these changes
Sep 12, 2023
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* update the lint:phpcs command * use Pantheon WP as the base * ignore the upstream configuration folder * document the exclude rule for plugins * carve out exclusions for config/application.php * rename to Pantheon * linting fixes * exclude blacklisted iniset
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* update the lint:phpcs command * use Pantheon WP as the base * ignore the upstream configuration folder * document the exclude rule for plugins * carve out exclusions for config/application.php * rename to Pantheon * linting fixes * exclude blacklisted iniset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging is blocked until pantheon-systems/Pantheon-WP-Coding-Standards#4 is merged.
This switches the repository to use
Pantheon-WP
as the PHPCS ruleset, rather than PSR-2 from the original Roots config.Uses WPCS 3.0, so should not be merged until the linked issue above is merged.