Update Sage Test workflow #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is happening inside a matrix so it will break if another run updates the upstream before the current one finishes
jazzsequence
changed the title
|
MacOS tests are failing on multidev creation with |
jazzsequence
pushed a commit
that referenced
this pull request
Jul 31, 2024
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* if there is no pr number, set pr_num to rel * use brackets for multidev_name vars * move workflow to pull_request instead of push * apply the upstream updates to the multisite this is happening inside a matrix so it will break if another run updates the upstream before the current one finishes * don't echo empty string * remove stray " * apply upstream updates as a step outside the matrix * get pr number from pull_request event * update fallback logic * use run number instead of pr * use new install terminus action
jazzsequence
pushed a commit
that referenced
this pull request
Aug 1, 2024
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* if there is no pr number, set pr_num to rel * use brackets for multidev_name vars * move workflow to pull_request instead of push * apply the upstream updates to the multisite this is happening inside a matrix so it will break if another run updates the upstream before the current one finishes * don't echo empty string * remove stray " * apply upstream updates as a step outside the matrix * get pr number from pull_request event * update fallback logic * use run number instead of pr * use new install terminus action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where Sage Test workflow fails on multidev creation because
{os}-{phpver}-(e.g.mac-81-) is not a valid multidev name.Some additional changes were made in this workflow to ensure consistency and future debugging. The trigger was updated to
pull_requestfrompushso closing, reopening, or transitions could trigger the workflow. Additionally, thepr_num(which is a misnomer now) logic was updated to use the GHA run number instead of the PR number. This way the number is more unique and there is less change of multidev name collisions when subsequent pushes are made to the same PR.An
Apply Upstream Updatesstep was broken out of the workflow and set as a dependency for the Sage tests because it was previously being run inside the matrix of tests. This meant that any test that found upstream updates could fail other tests that are checking for upstream updates at the same time.