Use terminus-github-actions and Sage install script cleanup
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than continuing if _not_ CI
rather than anything, we might get weird output if it's not true
pwtyler
approved these changes
May 6, 2024
private/scripts/helpers.sh
Outdated
| cd /files | ||
| mkdir cache | ||
| # Create a files/cache directory on the host if one does not already exist. | ||
| if [ "$(sftp -P 2222 "$sftpuser"@"$sftphost" <<< "ls /files" | grep -c "^cache$")" -eq 0 ]; then |
There was a problem hiding this comment.
would be nice if this is done with exit codes instead but maybe not worth the effort.
There was a problem hiding this comment.
I'm not sold on this yet as it still is getting a folder creation error in CI. Pretty sure this works if the script is run normally though and the script doesn't fail so ¯_(ツ)_/¯
so it looks slightly less weird that we're erroring if it's not
this will skip weird stuff and make the output more consistent
jazzsequence
changed the title
jazzsequence
changed the title
terminus-github-actions and Sage install script cleanup
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* put composer diff into a details block * use terminus-github-actions * skip things for CI-only runs * skip multisite stuff if we're not on multisite * add a workflow:wait to wait for the commit to finish before switching to sftp * bail early if CI rather than continuing if _not_ CI * check if is_multisite is 1 rather than anything, we might get weird output if it's not true * only create the directory if it doesn't exist * wrap statement in quotes * verbose output and ls the contents of /files * log that we're checking for multisite so it looks slightly less weird that we're erroring if it's not * remove ="" * use config is-true rather than config get * genrenate a random theme name * change our grep pattern * use `config is-true` directly * replace spaces with hyphens * remove non alphanumeric characters this will skip weird stuff and make the output more consistent
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* put composer diff into a details block * use terminus-github-actions * skip things for CI-only runs * skip multisite stuff if we're not on multisite * add a workflow:wait to wait for the commit to finish before switching to sftp * bail early if CI rather than continuing if _not_ CI * check if is_multisite is 1 rather than anything, we might get weird output if it's not true * only create the directory if it doesn't exist * wrap statement in quotes * verbose output and ls the contents of /files * log that we're checking for multisite so it looks slightly less weird that we're erroring if it's not * remove ="" * use config is-true rather than config get * genrenate a random theme name * change our grep pattern * use `config is-true` directly * replace spaces with hyphens * remove non alphanumeric characters this will skip weird stuff and make the output more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pantheon-systems/action-install-terminuswithpantheon-systems/terminus-github-actionssage-test)add_symlinkstep/files/cachedirectory exists before creating itwp config is-true(rather than runningtheme enableregardless)