[CMSP-1140] fix subdirectory paths #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can copy this pattern for subdomain and subdirectory multisites
maybe remove this from composite?
so they're easier to read in the action workflow
instead of the upstream name
this isn't relevant anymore
set the var to the id 🤦♂️
wp-admin links are actually okay. the /wp is stripped out of everything except the primary site admin but handled correctly
these were actually not working for anything
|
Ohhhh, the robot should not change composer files.... |
jazzsequence
force-pushed
the
cmsp-1140-fix-subdirectory-paths
branch
from
3f355ac to
7e122a8
Compare
jazzsequence
force-pushed
the
cmsp-1140-fix-subdirectory-paths
branch
from
34e0084 to
a2d5717
Compare
jazzsequence
added a commit
that referenced
this pull request
Jul 18, 2024
|
not sure why this is pulling the full history. closing and reopening a clean pr |
jazzsequence
added a commit
that referenced
this pull request
Jul 19, 2024
* port changes from #142 * remove no-longer-necessary id Co-authored-by: Phil Tyler <[email protected]> * execute and test in one step (instead of two) Co-authored-by: Phil Tyler <[email protected]> * remove the DIFF variable don't need it Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* port changes from #142 * remove no-longer-necessary id Co-authored-by: Phil Tyler <[email protected]> * execute and test in one step (instead of two) Co-authored-by: Phil Tyler <[email protected]> * remove the DIFF variable don't need it Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* port changes from #142 * remove no-longer-necessary id Co-authored-by: Phil Tyler <[email protected]> * execute and test in one step (instead of two) Co-authored-by: Phil Tyler <[email protected]> * remove the DIFF variable don't need it Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the unnecessary code for handling wp-admin URLs. The code was not working as intended and caused issues.
This has been tested on a subdirectory multisite (which was the only thing that was broken or affected). Subdomain multisite should be unaffected (there are conditionals specifically targeting subdirectory multisite) but will be tested as well assuming automated tests pass.
The primary issue was admin URLs which are not (currently) tested with automated testing.
blocked by #140