[CMSP-721] Ensure Behat tests are run on PHP 8.3 site environment #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already moved to GitHub Actions
so we don't need to prefix the 8.3 tests with 83
and we'll assume we can multidev off master still
jazzsequence
changed the title
This was referenced Nov 9, 2023
Merged
this will be broken until pantheon-systems/infrastructure#3574 is merged, but then we can re-run and it should work
|
I don't see anything here that looks related to New Relic, but I may be missing something. Approved with that note. |
rwagner00
approved these changes
Nov 16, 2023
pwtyler
pushed a commit
that referenced
this pull request
Oct 28, 2024
* remove the run_test command already moved to GitHub Actions * update prepare and cleanup steps for php 8.3 tests * add a separate php 8.3 test * update main jobs * remove non-existant --from-env * circle ci has different run numbers so we don't need to prefix the 8.3 tests with 83 * bump tested up to version * just use a single test and we'll assume we can multidev off master still * allow nonfatal newrelic error * send subshell errors to /dev/null * pass true to continue * use &1 * Ignore the newrelic error * add PHP version to behat-prepare so we can be sure that we're on 8.3 * restore the env:create to the way it was originally * move the quote * bump tested up to to 6.4.1 * return FIXTURE_VERSION to what it was originally this will be broken until pantheon-systems/infrastructure#3574 is merged, but then we can re-run and it should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't do much in itself. Most of the work of ensuring the Behat tests run on PHP 8.3 happen in the actual CI fixture site. However, there are a number of minor changes made here to ensure that the tests run correctly:
.circleci/config.ymlterminus env:infoto ensure we're testing on PHP 8.3ignores a NewRelic error when validating the tested-up-to version (see LOPS-1909)fixed by https://github.com/pantheon-systems/infrastructure/pull/3574