Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Tested up to" in Meta #301

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Update "Tested up to" in Meta #301

merged 16 commits into from
Oct 29, 2024

Conversation

miriamgoldman
Copy link

This PR updates the "Tested up to" in the plugin meta to match the most recent version.

jazzsequence and others added 5 commits November 16, 2023 08:34
@jazzsequence
[CMSP-721] Ensure Behat tests are run on PHP 8.3 site environment (#283)
552d36c 
* remove the run_test command
already moved to GitHub Actions

* update prepare and cleanup steps for php 8.3 tests

* add a separate php 8.3 test

* update main jobs

* remove non-existant --from-env

* circle ci has different run numbers
so we don't need to prefix the 8.3 tests with 83

* bump tested up to version

* just use a single test
and we'll assume we can multidev off master still

* allow nonfatal newrelic error

* send subshell errors to /dev/null

* pass true to continue

* use &1

* Ignore the newrelic error

* add PHP version to behat-prepare so we can be sure that we're on 8.3

* restore the env:create to the way it was originally

* move the quote

* bump tested up to to 6.4.1

* return FIXTURE_VERSION to what it was originally
this will be broken until pantheon-systems/infrastructure#3574 is merged, but then we can re-run and it should work
@jazzsequence
[BUGS-6643] workflow updates (#289)
904887d 
* add composer-diff workflow

* update wpunit-helpers to 2.0

* fix gitignore

* update lint-test workflow

* remove shellcheck step
most of the relevant scripts are from wpunit helpers or sourced from elsewhere. we should make a single solution for all copy/pasted scripts but we don't need to shellcheck in this individual implementation

* add release-pr workflow
copy pasta from papc

* add build-tag-release workflow
copy pasta from papc with composer and gitignore mods

* need to install WP-CLI for the new phpunit test

* update Contributing with new automated workflow

* update contributing.md with asset-only update process
@jazzsequence
Update CODEOWNERS for new team names (#296)
325a5eb
@miriamgoldman
updates tested up to meta, and bumps up version and changelog
26c278e
@miriamgoldman
adds change to markdown readme
5d8bed2
@miriamgoldman miriamgoldman requested a review from a team as a code owner October 15, 2024 12:11
@jazzsequence
Copy link
Contributor

Behat tests are failing because the fixture site is using 6.4.1. Should get the test site updated, make sure the Behat tests pass and then apply the change.

@pwtyler
Copy link
Member

pwtyler commented Oct 16, 2024 •
edited
Loading

This also needs to be merged to develop which in turn is also out of sync with the release. I'll try to do some cleanup today. @jazzsequence you free tomorrow? Maybe we can poke at the docs-only workflow with this project during CMSP work session.

@jazzsequence
Copy link
Contributor

Sorry @pwtyler only just seeing this comment 😅.
I can work on the fixture site today to ensure the version of WP installed is current and then we can merge into develop. I can look into the docs-only workflow we have elsewhere.

@jazzsequence jazzsequence changed the base branch from main to develop October 28, 2024 21:22
@github-actions GitHub Actions
Copy link

Composer Changes

Dev Packages Operation Base Target
pantheon-systems/pantheon-wordpress-upstream-tests Changed dev-master 004fc97 dev-master 1fa393d

@pwtyler
Copy link
Member

pwtyler commented Oct 28, 2024

Lets fix the develop branch and rebase this PR.

@pwtyler
Copy link
Member

pwtyler commented Oct 28, 2024

OK develop has been updated and rebased back on top of main which we never did following 1.4.3's release. I think we need to get all of the current CI changes into main so that we can then do an asset-only deploy from there to bump tested up to without cutting a release. Clearly we've not smoothed out this process just yet.

@jazzsequence
Copy link
Contributor

Well, you'll note that the plugin release actions were never merged to main either (probably because we didn't want to cut a release, but maybe that wouldn't have triggered anyway if it was CI-only changes).

@pwtyler pwtyler changed the base branch from develop to release October 29, 2024 18:28
pwtyler
pwtyler reviewed Oct 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pantheon-sessions.php Outdated Show resolved Hide resolved
pantheon-sessions.php Outdated Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
@pwtyler
Copy link
Member

pwtyler commented Oct 29, 2024

Final product of this PR to be merged to 'release':

  • Bump "tested up to"
  • Additional checks for asset-only release

@pwtyler pwtyler merged commit 13f0350 into release Oct 29, 2024
13 of 14 checks passed
@pwtyler pwtyler deleted the update-meta branch October 29, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwtyler pwtyler pwtyler left review comments

@jazzsequence jazzsequence jazzsequence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miriamgoldman @jazzsequence @pwtyler