Better handling when Redis is enabled, but unavailable or gone away #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the `WP_Redis` class. Because we're wrapping calls to Redis internally, we don't need a mock equivalent of the `Redis` class. * Distinguish error message between Redis not installed and Redis unavailable.
| } | ||
| } else { | ||
| class WP_Redis { | ||
| protected function _call_redis( $method ) { |
There was a problem hiding this comment.
I'm not a huge fan of prefixing methods with _, but the pattern is already established with _exists
`_call_redis()` checks our `is_redis_connected` class variable, which is set to false. We don't need the safety fallback here
Redis can go away on occasion. We want to make sure the relationship doesn't completely end.
danielbachhuber
changed the title
| $this->blog_prefix = $this->multisite ? $blog_id . ':' : ''; | ||
| if ( ! class_exists( 'Redis' ) ) { | ||
| $this->is_redis_connected = false; | ||
| $this->missing_redis_message = 'Alert! PHPRedis module is unavailable, which is required by WP Redis object cache.'; |
There was a problem hiding this comment.
@joshkoenig How do you feel about the language in this string?
This was referenced Oct 30, 2015
Merged
| @@ -769,18 +782,54 @@ public function __call( $name, $arguments ) { | |||
| case 'exists': | |||
| return false; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Would still be super-helpful to be able to (optionally) log failures here. i.e. https://github.com/pantheon-systems/wp-redis/pull/5/files#diff-5a2b681f0d32956de83215ea32388177R755
|
Language looks good to me. |
joshkoenig
pushed a commit
that referenced
this pull request
Oct 31, 2015
…back Better handling when Redis is enabled, but unavailable or gone away
|
Please consider that logging will likely be necessary in the event of Redis server failures: #18 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP_Redisclass. Because we're wrapping calls to Redisinternally, we don't need a mock equivalent of the
Redisclass.unavailable.
See #4, #8, #9