Catch Exceptions thrown during authentication

[danielbachhuber]

This will let us more easily catch an Exception if there's an error
connecting.

Fixes #34

[danielbachhuber]

@jtsternberg Can you try this out on your site with authentication and confirm it catches your Exception? I don't have an easy way of writing tests for the authentication case.

[danielbachhuber]

Actually, I take that back. Once #40 is merged, I can write a test for failed authentication.

[jtsternberg]

Changing to this actually caused my error log to explode w/ these errors (repetitively):

[18-Nov-2015 15:38:17 UTC] WP Redis: Failed to AUTH connection
[18-Nov-2015 15:38:17 UTC] WP Redis: Failed to AUTH connection
[18-Nov-2015 15:38:17 UTC] WP Redis: Failed to AUTH connection
[18-Nov-2015 15:38:17 UTC] WP Redis: Failed to AUTH connection
[18-Nov-2015 15:38:17 UTC] PHP Warning:  WP Redis: read error on connection in D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php on line 741

[danielbachhuber]

Changing to this actually caused my error log to explode w/ these errors (repetitively):

Ah, because it tries to reconnect repeatedly.

[jtsternberg]

Actually, it may have to do w/ my tweaks to the file. I think the issue is that this error ("Failed to AUTH connection") is not in the $retry_exception_messages array, so it doesn't actually try to reconnect.

[jtsternberg]

Ok, it most definitely has to do with $this->is_redis_connected not yet being set when $this->_call_redis( 'auth', $redis_server['auth'] ); is called. I think $this->is_redis_connected has to be set before AND after the auth call. (like so: http://b.ustin.co/XV5i)

[danielbachhuber]

Failing test case looks like this:

salty-wordpress ➜  wp-redis  phpunit --filter test_redis_bad_authentication
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
PHPUnit 4.4.1 by Sebastian Bergmann.

Configuration read from /srv/www/pantheon.dev/wp-content/plugins/wp-redis/phpunit.xml

E

Time: 2.31 seconds, Memory: 23.00Mb

There was 1 error:

1) CacheTest::test_redis_bad_authentication
RedisException: Redis server went away