Exit the script early if the class doesn't exist, or it's been manually disabled. #468
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* re-add missing else * use the already-defined value of $port instead of hard-coding * remove ternary in favor of elseif
…er issues (pantheon-systems#434) * fix: Fixes incorrect order of array_replace_recursive arguments & other issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use. * fix: Fixes sanitization methods and linting issues * Adjusts some items to use type-based sanitization. * Adds linting expection handling with comments for cases that require it. * fix: Removes invalid change made in pantheon-systems#437 * Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`. * update changelog * Update wp-redis.php * update language in changelogs * fix missing closing ) --------- Co-authored-by: Chris Reynolds <[email protected]> Co-authored-by: Phil Tyler <[email protected]>
* Bump behat/behat from 3.13.0 to 3.14.0 Bumps [behat/behat](https://github.com/Behat/Behat) from 3.13.0 to 3.14.0. - [Release notes](https://github.com/Behat/Behat/releases) - [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md) - [Commits](Behat/Behat@v3.13.0...v3.14.0) --- updated-dependencies: - dependency-name: behat/behat dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Upgrade yoast/phpunit-polyfills to 1.1.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
force-pushed
the
patch-5
branch
from
5af0f99 to
880f667
Compare
jazzsequence
approved these changes
Feb 18, 2025
|
Cleaned up the PR & merge conflicts |
EarthlingDavey
commented
Feb 19, 2025
| } | ||
|
|
||
| // Conditionally run the script if: the correct class exists, and the script has not been disabled. | ||
| if ( ! class_exists( WP_REDIS_USE_RELAY ? 'Relay\Relay' : 'Redis' ) && ( defined( 'WP_REDIS_DISABLED' ) && WP_REDIS_DISABLED ) ) { |
There was a problem hiding this comment.
Should this have an || in the middle?
if ( ! class_exists( WP_REDIS_USE_RELAY ? 'Relay\Relay' : 'Redis' ) || ( defined( 'WP_REDIS_DISABLED' ) && WP_REDIS_DISABLED ) ) {
In other words, if the class doesn't exist or WP Redis is disabled, then return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for your consideration:
There may be cases where the correct Redis class does not exist, this case will be handled gracefully.
Or there may be a case where the script needs to be disabled quickly without re-deployment, the ENV VAR
WP_REDIS_DISABLEDcan be used for this case.