Add Form::CheckBoxComponent #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spone
commented
Jun 26, 2021
71 tasks
Spone
force-pushed
the
check-box-component
branch
from
c7afc65
to
f2aa263
Compare
Spone
commented
Jun 29, 2021
Comment on lines
+14
to
+15
| %(<input name="user[admin]" type="hidden" value="0">) + | ||
| %(<input type="checkbox" value="1" name="user[admin]" id="user_admin">) |
There was a problem hiding this comment.
@nicolas-brousse idea for a better syntax? (without newlines and whitespace between the inputs)
There was a problem hiding this comment.
In our current project, I use to have this kind of tests.
expect(component.to_html.tr("\n", "")).to eq <<~HTML.tr("\n", "").strip
<label class="form-checkbox" for="user_is_enabled">
<input name="user[is_enabled]" type="hidden" value="0">
<input class="form-checkbox__input" type="checkbox" value="1" name="user[is_enabled]" id="user_is_enabled">
<span class="form-checkbox__label">Actif</span>
</label>
HTMLIt's not the cleanest. Maybe we may create a custom matcher like
expect(component).to have_html <<~HTML
<label class="form-checkbox" for="user_is_enabled">
<input name="user[is_enabled]" type="hidden" value="0">
<input class="form-checkbox__input" type="checkbox" value="1" name="user[is_enabled]" id="user_is_enabled">
<span class="form-checkbox__label">Actif</span>
</label>
HTMLThere was a problem hiding this comment.
Yes, let's create a custom matcher, can you open a PR for it?
nicolas-brousse
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4