Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install headers again #178

Merged
merged 1 commit into from
Jan 19, 2024
Merged

install headers again #178

merged 1 commit into from
Jan 19, 2024

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Jan 17, 2024

fixup 24ae2d7

Actually install headers and do not redundantly add the include dir to the target.

INCLUDES DESTINATION flags in install(TARGETS define additional paths that are added to the INTERFACE_INCLUDE_DIRECTORIES, they do not install files.

Actually install headers and do not redundantly add the include dir to the target.
`INCLUDES DESTINATION` flags in `install(TARGETS` define additional paths that are
added to the INTERFACE_INCLUDE_DIRECTORIES, they do not install files.
@pantor pantor merged commit bef286c into pantor:main Jan 19, 2024
7 checks passed
@pantor
Copy link
Owner

pantor commented Jan 19, 2024

Thanks!

I still sometimes find the CMake installation and packaging stuff a bit confusing - I'm assuming the PUBLIC_HEADER flag is what I actually wanted.

Greetings from Hamburg to Hamburg,
Lars

@v4hn
Copy link
Contributor Author

v4hn commented Jan 19, 2024

I'm assuming the PUBLIC_HEADER flag is what I actually wanted.

I guess that would work, but it's another mechanism in parallel to INTERFACE_INCLUDE_DIRECTORIES of the library targets. Imho installing the include folder seems more readable.

Greetings from Hamburg to Hamburg

If you are around anyway, I would be happy to invite you to our lab for a visit and short talk on your work. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants