Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PBS generate_urls.py housekeeping script with resolve and options #21674

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Nov 20, 2024

Some small updates to the PBS generate_urls.py housekeeping script:

  • Put the script into a pbs-script resolve to isolate its dependencies.
  • Add a pex_binary target for running the script.
  • Use argparse to add new options --scrape-all-releases and --scrape-release=RELEASE for forcing the script to re-process already-scraped releases. I am using these for another PR where I modified the data format for versions_info.json and need to rescrape the PBS release data.
  • The build root check is now just a check that the script is being run from the root of a Pants repository (via presence of the expected subdirectories). (This avoids needing to import get_buildroot from the other Pants sources.)

@tdyas tdyas added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Nov 20, 2024
@tdyas tdyas requested review from cburroughs and benjyw November 20, 2024 17:56
@tdyas tdyas merged commit 6cac603 into pantsbuild:main Nov 21, 2024
24 checks passed
@tdyas tdyas deleted the pbs/generate-url-improvements branch November 21, 2024 14:07
name="pbs-script",
source="pbs-script-requirements.txt",
resolve="pbs-script",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be added to build-support/bin/generate_builtin_lockfiles.py, or are 'script' lockfiles different from builtin ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pbs-script resolve is only intended for use within the Pants repository itself, and so does not seem to me like a "tool" lockfile which is bundled with Pants for use by end users. So it can probably be excluded from this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants