Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to publish docker images non-interactively. #21880

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

trhodeos
Copy link
Contributor

Fixes #17613

@trhodeos trhodeos marked this pull request as ready for review January 28, 2025 22:05
@cburroughs cburroughs self-requested a review January 28, 2025 22:06
@trhodeos trhodeos force-pushed the tr.backgroundPublish branch from e4ef999 to 15b0f80 Compare January 28, 2025 22:19
@trhodeos trhodeos closed this Jan 29, 2025
@trhodeos trhodeos reopened this Jan 29, 2025
@trhodeos
Copy link
Contributor Author

Not sure why/how I closed this... Reopening.

@huonw
Copy link
Contributor

huonw commented Feb 6, 2025

Thanks for contributing, and thanks for waiting for a review.

We've just branched for 2.25, so merging this pull request now will come out in 2.26, please move the release notes updates to docs/notes/2.26.x.md. Thank you!

@cburroughs
Copy link
Contributor

cburroughs commented Feb 13, 2025

Pulling in some comments from chat:

I was able to sustain 1 Gbps for several minutes of pushing, I have this spiffy workunit trace:
image

So I'm feeling pretty good that the pushing really is working in parallel, yeah! 🚀

Same way to still print the lines:

a492eee5e559: Layer already exists 
7576b00d9bb1: Layer already exists 
2260218218a7: Already exists 
3fd67c6ea721: Layer already exists 
be92f6592e6d: Layer already exists 
dcaa1b9153e7: Layer already exists 
32b550be6cb6: Layer already exists 
2d2bff40c204: Layer already exists 
8630e3071c88: Layer already exists 
6cb66cb5f02b: Layer already exists 
35af2a7690f2: Layer already exists 

And nit, move the release note to the 2.26.x file.

@cburroughs
Copy link
Contributor

oh and you probably saw this, but src/python/pants/core/goals/publish_test.py is failing in the latest commit.

Thanks for flying this to the finish line!

@trhodeos trhodeos force-pushed the tr.backgroundPublish branch from f6bbfc0 to b677a23 Compare February 14, 2025 18:35
@trhodeos
Copy link
Contributor Author

Ok, tests and docs are updated / fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the publish goal for Docker images to push images in parallel
3 participants