GPA Improvements: 1.15 to 2.02

.codeclimate.yml

@@ -0,0 +1,20 @@
+---
+engines:
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - ruby
+
+  fixme:
+    enabled: true
+
+  rubocop:
+    enabled: true
+
+ratings:
+  paths:
+  - "**.rb"
+
+exclude_paths: 
+- lib/papertrail/okjson.rb

Rakefile

@@ -115,7 +115,7 @@ desc "Generate #{gemspec_file}"
 task :gemspec => :validate do
   # read spec file and split out manifest section
   spec = File.read(gemspec_file)
-  head, manifest, tail = spec.split("  # = MANIFEST =\n")
+  head, _manifest, tail = spec.split("  # = MANIFEST =\n")
 
   # replace name version and date
   replace_header(head, :name)

lib/papertrail/cli.rb

@@ -29,7 +29,7 @@ def initialize
     end
 
     def run
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end
@@ -38,11 +38,11 @@ def run
         opts.banner  = "papertrail - command-line tail and search for Papertrail log management service"
         opts.version = Papertrail::VERSION
 
-        opts.on("-h", "--help", "Show usage") do |v|
+        opts.on("-h", "--help", "Show usage") do
           puts opts
           exit
         end
-        opts.on("-f", "--follow", "Continue running and printing new events (off)") do |v|
+        opts.on("-f", "--follow", "Continue running and printing new events (off)") do
           options[:follow] = true
         end
         opts.on("--min-time MIN", "Earliest time to search from") do |v|
@@ -66,15 +66,15 @@ def run
         opts.on("-s", "--system SYSTEM", "System to search") do |v|
           options[:system] = v
         end
-        opts.on("-j", "--json", "Output raw JSON data (off)") do |v|
+        opts.on("-j", "--json", "Output raw JSON data (off)") do
           options[:json] = true
         end
-        opts.on("--color [program|system|all|off]",
-                [:program, :system, :all, :off],
-                "Attribute(s) to colorize based on (program)") do |v|
+        opts.on("--color [program|system|all|off]", 
+          [:program, :system, :all, :off], "Attribute(s) to colorize based on (program)") do |v|
+
           options[:color] = v
         end
-        opts.on("--force-color", "Force use of ANSI color characters even on non-tty outputs (off)") do |v|
+        opts.on("--force-color", "Force use of ANSI color characters even on non-tty outputs (off)") do
           options[:force_color] = true
         end
         opts.on("-V", "--version", "Display the version and exit") do |v|

lib/papertrail/cli_add_group.rb

@@ -14,15 +14,15 @@ def run
         :token => ENV['PAPERTRAIL_API_TOKEN'],
       }
 
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end
 
       OptionParser.new do |opts|
         opts.banner = "papertrail-add-group"
 
-        opts.on("-h", "--help", "Show usage") do |v|
+        opts.on("-h", "--help", "Show usage") do
           puts opts
           exit
         end

lib/papertrail/cli_add_system.rb

@@ -16,7 +16,7 @@ def run
         :token => ENV['PAPERTRAIL_API_TOKEN'],
       }
 
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end
@@ -59,7 +59,7 @@ def run
         opts.separator ''
         opts.separator "Common options:"
 
-        opts.on("-h", "--help", "Show usage") do |v|
+        opts.on("-h", "--help", "Show usage") do
           puts opts
           exit
         end

lib/papertrail/cli_helpers.rb

@@ -1,10 +1,14 @@
 module Papertrail
   module CliHelpers
+    def configfile
+      @configfile ||= find_configfile
+    end
+
     def find_configfile
-      if File.exists?(path = File.expand_path('.papertrail.yml'))
+      if File.exist?(path = File.expand_path('.papertrail.yml'))
         return path
       end
-      if File.exists?(path = File.expand_path('~/.papertrail.yml'))
+      if File.exist?(path = File.expand_path('~/.papertrail.yml'))
         return path
       end
     rescue ArgumentError

lib/papertrail/cli_join_group.rb

@@ -14,7 +14,7 @@ def run
         :token => ENV['PAPERTRAIL_API_TOKEN'],
       }
 
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end

lib/papertrail/cli_leave_group.rb

@@ -14,7 +14,7 @@ def run
         :token => ENV['PAPERTRAIL_API_TOKEN'],
       }
 
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end

lib/papertrail/cli_remove_system.rb

@@ -14,7 +14,7 @@ def run
         :token => ENV['PAPERTRAIL_API_TOKEN'],
       }
 
-      if configfile = find_configfile
+      if configfile
         configfile_options = load_configfile(configfile)
         options.merge!(configfile_options)
       end

lib/papertrail/http_client.rb

@@ -42,47 +42,27 @@ def get(path, params = {})
       if params.size > 0
         path = "#{path}?#{build_nested_query(params)}"
       end
-      attempts = 0
-      begin
+
+      attempt 3, 5.0 do
         on_complete(https.get(request_uri(path), @headers))
-      rescue SystemCallError, Net::HTTPFatalError => e
-        sleep 5.0
-        attempts += 1
-        retry if (attempts < 3)
-        raise e
       end
     end
 
     def put(path, params)
-      attempts = 0
-      begin
+      attempt do
         on_complete(https.put(request_uri(path), build_nested_query(params), @headers))
-      rescue SystemCallError, Net::HTTPFatalError => e
-        attempts += 1
-        retry if (attempts < 3)
-        raise e
       end
     end
 
     def post(path, params)
-      attempts = 0
-      begin
+      attempt do
         on_complete(https.post(request_uri(path), build_nested_query(params), @headers))
-      rescue SystemCallError, Net::HTTPFatalError => e
-        attempts += 1
-        retry if (attempts < 3)
-        raise e
       end
     end
 
     def delete(path)
-      attempts = 0
-      begin
+      attempt do
         on_complete(https.delete(request_uri(path), @headers))
-      rescue SystemCallError, Net::HTTPFatalError => e
-        attempts += 1
-        retry if (attempts < 3)
-        raise e
       end
     end
 
@@ -156,6 +136,21 @@ def escape(s)
         '%' + $&.unpack('H2' * $&.bytesize).join('%').upcase
       }.tr(' ', '+')
     end
+
+    def attempt(tries=3, wait=nil)
+      return unless block_given?
+
+      attempts = 0
+      begin
+        yield
+      rescue => e
+        sleep wait if wait
+        attempts += 1
+        retry if (attempts < tries)
+        raise e
+      end
+    end
+
   end
 
 end