Update for Gnome 45

[jtaala]

Fixes #576

Gnome 45 will require every gnome extension to be updated in order to work in 45. That is, no previous extensions will work on 45 due to moving to ECMAScript modules (meaning that the previous gnome extensions imports won't work).

This PR is for implementing full Gnome 45 support in PaperWM.

Update: It is done - long live Gnome 45!

[jtaala]

GNOME 45 includes new activity button

Hey @paradajz - please pull the latest on this branch and from a terminal run:

dconf write /org/gnome/shell/extensions/paperwm/show-workspace-indicator false

Which will disable the PaperWM workspace indicator and use the new Gnome activities element instead.

Let me know how it goes.

[jtaala]

P.S. I've also changed the scrolling behaviour on PaperWM workspace element to sequence (not stack) - this is to align with Gnome Activities behaviour here (and it makes more sense).

#604.

[paradajz]

Great. It works. However now I've noticed two things:

1. My shortcuts for moving windows to the next/previous workspace don't work anymore - I am not sure if this PR changed something or did G45 override something. The shortcuts are Ctrl+Shift+Left for moving to the left workspace and Ctrl+Shift+Right to the right. When I press this combination what I get instead is switching between workspaces in order. This combination isn't used anywhere else. I've also tried to change the shortcuts to use PageUp/Down instead of left/right arrows and I get the same issue. Two meta issues here:
   a) Since GNOME doesn't have vertical workspaces anymore, maybe the better wording would be to move to workspaces left/right instead of up/down in the preferences
   b) The workspace switching animation also uses vertical animation instead of horizontal

2. Every single option in the keybindings section is trimmed:

[paradajz]

One other thing: With PaperWM enabled and new activity button enabled, scrolling the workspaces doesn't use the GNOME animation. When PaperWM is disabled, animation is present.

[jtaala]

1. My shortcuts for moving windows to the next/previous workspace don't work anymore

Well, let's looks at this one first. Can you please pull the latest and test. Was a regression from an extra = that was added (harder equality).

[jtaala]

2. Every single option in the keybindings section is trimmed

Hmmm - I'm not seeing this, and you're close button is on the left(?) which is different than standard gnome stuff. Are you running another extension to change these elements / themes?

This is what I'm seeing:

[jtaala]

One other thing: With PaperWM enabled and new activity button enabled, scrolling the workspaces doesn't use the GNOME animation. When PaperWM is disabled, animation is present.

I was wondering about this, I thought it strange that there was no animation - will have a look at this tomorrow.

[paradajz]

1. My shortcuts for moving windows to the next/previous workspace don't work anymore

Well, let's looks at this one first. Can you please pull the latest and test. Was a regression from an extra = that was added (harder equality).

Works now! Thanks!

Hmmm - I'm not seeing this, and you're close button is on the left(?) which is different than standard gnome stuff. Are you running another extension to change these elements / themes?

No, it's just an option in GNOME Tweak Tool:

However I do run with scaling factor set to 0.9 for years now on this monitor (looks better to me). Tried to set it to 1 and yeah, now the options aren't trimmed anymore. Not sure if this is something for you to look at then.

[jtaala]

@Lythenas, I've still got to merge this at some point.

What do you recon? when we merge this, should be switch back to develop branch as default? Given if users what a more stable release they could just use the EGO version?

I think it's ready - although I won't be on Gnome 45 until Arch switches to it (Arch usually waits a bit for Gnome releases). Still using 44 for my daily driver and dev'ing Gnome 45 in a libvirt virtual machine.

[Lythenas]

I think merging this into develop is probably fine. I think the message in the readme is clear enough.

For people that are just going to pull on gnome 44 and less this will break the extension. But not sure how we could prevent that.

As for testing I will also switch once Gnome 45 is available on Arch. Before that I can't really test multi monitor support. Everything else seems to work fine in a VM as far as I can tell. But I didn't test that thoroughly.

[jtaala]

Okay, I'm about ready to merge this in and make it default for develop and release branches.

Note, I'm also now on gnome 45 for Arch (using FCGU gnome arch repo).