Fix date selector. Simplifies logic and removes unused code. dateIsSi… #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnificant at the moment always returns false causing an early return b/c the value is not set and has no previously selected value. Update to combobox select .prev('select') fixes the change in the composing of the combobox to ensure the select target is correct (now it's a span following the select whereas it was a class on the select element)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gnificant at the moment always returns false causing an early return b/c the value is not set and has no previously selected value. Update to combobox select .prev('select') fixes the change in the composing of the combobox to ensure the select target is correct (now it's a span following the select whereas it was a class on the select element)