chore: remove default bound for txs (#12834)

paradigmxyz · Nov 24, 2024 · 02824da · 02824da
1 parent 53839a9
commit 02824da
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 20 deletions.
diff --git a/crates/primitives-traits/src/node.rs b/crates/primitives-traits/src/node.rs
@@ -42,16 +42,7 @@ pub trait NodePrimitives:
         + MaybeSerde
         + 'static;
     /// Signed version of the transaction type.
-    type SignedTx: Send
-        + Sync
-        + Unpin
-        + Clone
-        + Default
-        + fmt::Debug
-        + PartialEq
-        + Eq
-        + MaybeSerde
-        + 'static;
+    type SignedTx: Send + Sync + Unpin + Clone + fmt::Debug + PartialEq + Eq + MaybeSerde + 'static;
     /// Transaction envelope type ID.
     type TxType: Send + Sync + Unpin + Clone + Default + fmt::Debug + PartialEq + Eq + 'static;
     /// A receipt.

diff --git a/crates/primitives-traits/src/transaction/mod.rs b/crates/primitives-traits/src/transaction/mod.rs
@@ -18,7 +18,6 @@ pub trait Transaction:
     + Sync
     + Unpin
     + Clone
-    + Default
     + fmt::Debug
     + Eq
     + PartialEq
@@ -35,7 +34,6 @@ impl<T> Transaction for T where
         + Sync
         + Unpin
         + Clone
-        + Default
         + fmt::Debug
         + Eq
         + PartialEq

diff --git a/crates/primitives-traits/src/transaction/signed.rs b/crates/primitives-traits/src/transaction/signed.rs
@@ -18,7 +18,6 @@ pub trait SignedTransaction:
     + Sync
     + Unpin
     + Clone
-    + Default
     + fmt::Debug
     + PartialEq
     + Eq

diff --git a/crates/primitives/src/transaction/pooled.rs b/crates/primitives/src/transaction/pooled.rs
@@ -11,7 +11,7 @@ use crate::{
 use alloy_consensus::{
     constants::EIP4844_TX_TYPE_ID,
     transaction::{TxEip1559, TxEip2930, TxEip4844, TxLegacy},
-    SignableTransaction, Signed, TxEip4844WithSidecar,
+    Signed, TxEip4844WithSidecar,
 };
 use alloy_eips::{
     eip2718::{Decodable2718, Eip2718Result, Encodable2718},
@@ -226,12 +226,6 @@ impl PooledTransactionsElement {
     }
 }
 
-impl Default for PooledTransactionsElement {
-    fn default() -> Self {
-        Self::Legacy(TxLegacy::default().into_signed(Signature::test_signature()))
-    }
-}
-
 impl Hash for PooledTransactionsElement {
     fn hash<H: Hasher>(&self, state: &mut H) {
         self.trie_hash().hash(state);