Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): do not run hive on legacy engine #11733

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore(ci): do not run hive on legacy engine #11733

merged 1 commit into from
Oct 15, 2024

Conversation

fgimenez
Copy link
Member

Now that the experimental engine is released we don't need to keep running hive on the legacy engine

  • remove engine dimension in workflow matrix
  • do not modify hive reth client to run the test (no need to pass --engine.experimental)
  • remove expected_failures.yml and rename expected_failures_experimental.yml -> expected_failures.yml

@fgimenez fgimenez added C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools labels Oct 15, 2024
mattsse
mattsse approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@fgimenez
Copy link
Member Author

successful execution here with these settings https://github.com/paradigmxyz/reth/actions/runs/11341941367

@fgimenez fgimenez added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit e92fbae Oct 15, 2024
56 checks passed
@fgimenez fgimenez deleted the fgimenez/disable-legacy-engine-hive branch October 15, 2024 08:52
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
@fgimenez @reymom
chore(ci): do not run hive on legacy engine (paradigmxyz#11733)
b48c3f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools C-hivetest Used for labelling automated issues relating to hive test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @mattsse