Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update el requests for devnet 4 #11865

Merged
merged 3 commits into from
Oct 19, 2024
Merged

feat: update el requests for devnet 4 #11865

merged 3 commits into from
Oct 19, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Oct 18, 2024 •
edited
Loading

Bumps reth and alloy, and makes changes to how requests are handled throughout reth (both in syncing and in building) in preparation for devnet 4. Specifically:

  • Requests are now opaque and can be ferried around as-is in the representation their respective system contracts return them
  • We no longer need to serialize or deserialize requests, ever
  • We only need to perform 1 check for request validity: that requests_hash in the header matches requests_hash that we computed
  • requests_root has been replaced with a requests_hash

This also removes the Requests table, and removes requests from P2P, as it doesn't make sense to gossip requests, and I think we're the only ones doing it (oops). Wrt removing Requests, there are still no RPC endpoints that expose them, so I think we should remove it as it was prematurely added. It does not make sense to expose the requests over RPC anyway, as they are now opaque types only meant for the CL.

See

Depends on

@onbjerg onbjerg force-pushed the onbjerg/devnet-4-requests branch 2 times, most recently from 236c1fe to 3cfd2ba Compare October 18, 2024 02:10
@onbjerg
Copy link
Member Author

onbjerg commented Oct 18, 2024

This also requires a lot of changes in op-alloy it seems. Seems like there were a lot of breaking changes in this alloy bump :)

@onbjerg onbjerg force-pushed the onbjerg/devnet-4-requests branch 27 times, most recently from d9f63a5 to b504da3 Compare October 18, 2024 14:30
@onbjerg onbjerg force-pushed the onbjerg/devnet-4-requests branch 2 times, most recently from 6063dfb to 0eba493 Compare October 19, 2024 12:10
@onbjerg onbjerg marked this pull request as ready for review October 19, 2024 12:36
mattsse
mattsse approved these changes Oct 19, 2024
View reviewed changes
bin/reth/src/commands/debug_cmd/replay_engine.rs
Comment on lines +174 to +176
// todo: prague (last arg)
let response =
beacon_engine_handle.new_payload(payload, cancun_fields, None).await?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take care of in followup

@onbjerg onbjerg added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit 3bd695e Oct 19, 2024
40 checks passed
@onbjerg onbjerg deleted the onbjerg/devnet-4-requests branch October 19, 2024 13:04
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
bb148ad 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <[email protected]>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <[email protected]>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
b268f83 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <[email protected]>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <[email protected]>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
0971015 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <[email protected]>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <[email protected]>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed commit of the following:
90307b6 
commit 1a1aa2f
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <[email protected]>

commit 3bd695e
Author: Oliver <[email protected]>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <[email protected]>

commit 2ae9368
Author: Arsenii Kulikov <[email protected]>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

commit a4126b3
Author: greged93 <[email protected]>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <[email protected]>

commit 655fc1a
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <[email protected]>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <[email protected]>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <[email protected]>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
60bf4b7 
commit 1a1aa2f
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <[email protected]>

commit 3bd695e
Author: Oliver <[email protected]>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <[email protected]>

commit 2ae9368
Author: Arsenii Kulikov <[email protected]>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <[email protected]>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <[email protected]>

commit 655fc1a
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <[email protected]>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <[email protected]>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <[email protected]>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
aba5cb7 
commit 1a1aa2f
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <[email protected]>

commit 3bd695e
Author: Oliver <[email protected]>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <[email protected]>

commit 2ae9368
Author: Arsenii Kulikov <[email protected]>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <[email protected]>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <[email protected]>

commit 655fc1a
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <[email protected]>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <[email protected]>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <[email protected]>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
cf94e9e 
commit 1a1aa2f
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <[email protected]>

commit 3bd695e
Author: Oliver <[email protected]>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <[email protected]>

commit 2ae9368
Author: Arsenii Kulikov <[email protected]>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <[email protected]>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <[email protected]>

commit 655fc1a
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <[email protected]>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <[email protected]>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <[email protected]>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
onbjerg added a commit that referenced this pull request Oct 19, 2024
@onbjerg
chore: use Requests instead of Vec<Bytes>
2f7a620 
Follow up on #11865
This was referenced Oct 19, 2024
Merged
Merged
@rkrasiuk rkrasiuk added the S-breaking This PR includes a breaking change label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
S-breaking This PR includes a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onbjerg @mattsse @rkrasiuk