-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reth test-vectors compact --write|--read
#11954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these helper functions to generate test vectors and we run this once to get static test vectors
or are these always generated?
we can do both
I was leaning towards this one. during PR CI, generate with |
ad05e60
to
cbe43c8
Compare
cbe43c8
to
c3c09c9
Compare
76fb9ce
to
e7c59cd
Compare
8116c45
to
8aaaa4c
Compare
b1b91f0
to
a4db8ee
Compare
reth test-vectors compact --write|--read
to CIreth test-vectors compact --write|--read
1140630
to
bbf76f0
Compare
bbf76f0
to
c482a9d
Compare
c482a9d
to
c6786c8
Compare
5261d37
to
03e3eec
Compare
bb9ae1c
to
4d35814
Compare
4d35814
to
2058dde
Compare
looks like the only thing missing here is some op feature combination |
closes #11924
a) checkout
main
b) randomly generate and serialize to disk many different type vectors with
Compact
(eg. Headers, Transaction, etc)c) checkout
pr
d) deserialize previously generated test vectors
test_decode
tests for transaction types, receipt and headers.This ensures that the PR does not introduce a non-backwards compatible change to a type that implements
Compact
.For now, the CI job is disabled. It would fail since
main
does not have the command. It will be enabled later on.--
There's some follow-ups to be done here:
add op-reth test-vectors compact --write|--read
to CI #11994