Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(op): simplify blob fields in newly built block header #12035

Merged
merged 1 commit into from
Oct 26, 2024
Merged

chore(op): simplify blob fields in newly built block header #12035

merged 1 commit into from
Oct 26, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Oct 24, 2024 •
edited
Loading

Simplify some no-ops, replace an Ethereum hardfork check with OP's, and remove revm-primitives as a dependency for OP payload building.

mattsse
mattsse requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I had this in the blocklog for a while because this is basically always a noop. but the fields are still real and must adhere to fork activation

crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Oct 24, 2024
mattsse
mattsse approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is a nice cleanup

@mattsse
Copy link
Collaborator

mattsse commented Oct 26, 2024

unfortunately I can't push to org branches

this has a smol conflict that must be resolved first

@hai-rise
Copy link
Contributor Author

@mattsse No worries, I've rebased 🙏.

@mattsse mattsse added this pull request to the merge queue Oct 26, 2024
Merged via the queue into paradigmxyz:main with commit ab07fcf Oct 26, 2024
41 checks passed
@hai-rise hai-rise deleted the op-blobs branch November 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-rise @mattsse