fix: txpool race condition #12322
Closed
fix: txpool race condition #12322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
gakonst
as code owners
mattsse
requested changes
Nov 5, 2024
| @@ -327,7 +333,7 @@ where | |||
|
|
|||
| let account = match self | |||
| .client | |||
| .latest() | |||
| .state_by_block_hash(at) | |||
There was a problem hiding this comment.
I think this is now slightly problematic, because by the time this is executed, the hash could have been reorged and could result in an error
klkvr
force-pushed
the
klkvr/pool-race-condition
branch
from
8ff3fe4 to
7dc5cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12287
Closes #12286
Changes in this PR:
TransactionValidatornow acceptsat: B256argument to functions performing validation which should be used as a block at which transaction should be validated. We are passing latest block seen by the pool to it to ensure thaton_chain_nonce/on_chain_balancevalues are correct with the current view of the pooltransaction_import_lockfield is added to pool which is a simpleRwLock. It is used to ensure that pool is not processing canonical chain update while importing transactions. This allows us to make sure that transaction validation result is always valid for tx insertionPendingPool::add_transactionis changed to not make any assumptions on order if which transactions are being added. Earlier it would assume that it receives transaction in ascening nonce order. It is done by keeping a mapping fromSenderIdto -> highest/lowest nonce.