Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): improve usability BlockBody and Block traits #12450

Closed
wants to merge 1 commit into from
Closed

chore(sdk): improve usability BlockBody and Block traits #12450

wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 11, 2024 •
edited
Loading

Closes #12544

Makes BlockBody methods callable on any type that impls Block by importing reth_primtives_traits::block_prelude::*. Allows for removing a lot of methods for SealedBlock which just delegate to the body.

@emhane emhane added C-debt A clean up/refactor of existing code A-sdk Related to reth's use as a library labels Nov 11, 2024
@emhane emhane marked this pull request as draft November 11, 2024 13:35
This was referenced Nov 11, 2024
Closed
Merged
Base automatically changed from emhane/signed-tx to main November 13, 2024 13:51
@emhane emhane marked this pull request as ready for review November 14, 2024 16:20
@emhane emhane changed the base branch from main to emhane/tx-type November 14, 2024 16:54
@emhane emhane mentioned this pull request Nov 14, 2024
Closed
Base automatically changed from emhane/tx-type to main November 15, 2024 13:46
@emhane emhane mentioned this pull request Nov 15, 2024
Closed
@emhane emhane enabled auto-merge November 17, 2024 13:46
@emhane emhane changed the base branch from main to emhane/block-header November 19, 2024 13:33
@emhane emhane changed the title chore(sdk): improve usability block primitive traits chore(sdk): improve usability BlockBody and Block trait Nov 19, 2024
@emhane emhane changed the title chore(sdk): improve usability BlockBody and Block trait chore(sdk): improve usability BlockBody and Block traits Nov 19, 2024
auto-merge was automatically disabled November 19, 2024 13:36

Merge commits are not allowed on this repository

@emhane emhane changed the base branch from emhane/block-header to main November 24, 2024 09:18
@emhane emhane requested a review from klkvr as a code owner November 24, 2024 09:18
mattsse
mattsse reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're okay with the extra delegate to body()

then we don't need to add all the defaults

@mattsse mattsse closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@shekhirin shekhirin Awaiting requested review from shekhirin

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend BlockBody trait
2 participants
@emhane @mattsse