Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trie): turn TrieWitness methods into public functions #12510

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Nov 13, 2024

Towards #12053
Required for #12458

Extracted and adapted from #11154, the new public functions are target_nodes and next_root_from_proofs

@fgimenez fgimenez added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Nov 13, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/trie/trie/src/witness.rs Outdated Show resolved Hide resolved
crates/trie/trie/src/witness.rs Outdated Show resolved Hide resolved
@rkrasiuk
Copy link
Member

@fgimenez pending conflict

@fgimenez fgimenez added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 1d2934b Nov 18, 2024
41 checks passed
@fgimenez fgimenez deleted the fgimenez/witness-pub-fns branch November 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants