fix: do not delegate is_optimism check for Ethereum ChainSpec #12650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
Rjected,
joshieDo,
mattsse and
emhane
as code owners
|
Successful hive execution from this branch https://github.com/paradigmxyz/reth/actions/runs/11910257420 |
mattsse
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_optimismshould always be false for Ethereum'sChainSpec, otherwise it could return true for an Ethereum chain spec if the chain id is one of Optimism's chains.This was causing hive tests to fail https://github.com/paradigmxyz/reth/actions/runs/11903470318/job/33171134482 will retrigger on this branch.