Revert "chore(sdk): Add MaybeArbitrary as super trait" #12809
Merged
+131
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ebb4fc2.
mattsse
requested review from
Rjected,
joshieDo,
emhane,
klkvr,
fgimenez and
gakonst
as code owners
|
ok @mattsse , thanks for communicating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12661
@emhane I'm reverting this because this did not pass ci.
I thought the fix is as simple as #12807 but this didn't fix it entirely, so I reverted this as well...
can't figure out where the feature issue is, so until then I'm undoing this pr, and will reopen the revert of this pr again