feat(engine, trie): fetch blinded nodes when removing a sparse trie leaf #12962
+202
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/remove-leaf-fetch-node
branch
from
8f71379
to
52d24e6
Compare
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/remove-leaf-fetch-node
branch
from
52d24e6
to
f81dd65
Compare
shekhirin
requested review from
rkrasiuk,
Rjected,
mattsse and
fgimenez
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a child of a branch node with two children set, the only remaining child needs to be collapsed with the branch node, and for that we need to have it revealed, which may not always be the case.