Implement ECDSA keymgmt and signatures #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,8 @@ use crate::openssl_bindings::*; | |||
| use crate::{ | |||
There was a problem hiding this comment.
nit: Commit description should say changed to an ECDSA function.?
There was a problem hiding this comment.
Could you tell me the SHA of the commit or the title?
There was a problem hiding this comment.
I think the description is clear enough. It does not change to a function, but rather it just says that it uses a new implementation table for ECDSA. What do you think?
Copy RSA's implementation table and use it for ECDSA. Each function in that implementation table will be sequentially changed to an RSA function. Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/ecdsa_keymgmt-pr
branch
from
bede2d2
to
a526c7e
Compare
tgonzalezorlandoarm
force-pushed
the
tg/ecdsa_keymgmt-pr
branch
4 times, most recently
from
db30df1
to
e0caa84
Compare
tgonzalezorlandoarm
force-pushed
the
tg/ecdsa_keymgmt-pr
branch
2 times, most recently
from
f3825f8
to
ac2a1b0
Compare
tgonzalezorlandoarm
force-pushed
the
tg/ecdsa_keymgmt-pr
branch
3 times, most recently
from
4d5fc77
to
0582828
Compare
As EcPoint does not implement the clone trait, the current implementation of keymgmt duplication does not work. Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/ecdsa_keymgmt-pr
branch
from
0582828
to
de67475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.