adds a `signature::Signer` interface #537

baloo · 2024-08-03T23:16:03Z

This brings an implementation of a signature::Signer for keys stored on the TPM.

This is intend to make for easier re-use of this crate and to allow to:

Create certificates https://docs.rs/x509-cert/latest/x509_cert/builder/struct.CertificateBuilder.html
Create CSRs https://docs.rs/x509-cert/latest/x509_cert/builder/struct.RequestBuilder.html
Sign documents with S/MIME https://docs.rs/cms/latest/cms/builder/index.html

Here is an implementation of an SSH agent making use of that infrastructure: wiktor-k/ssh-agent-lib#87

Superhepper

Sorry for reviewing a WIP though I found it a little bit interesting so I couldn't help my self. Feel free to disregard anything I have commented on.

tss-esapi/src/abstraction/public.rs

tss-esapi/src/abstraction/transient/signer.rs

tss-esapi/src/interface_types/algorithm.rs

tss-esapi/src/structures/signatures.rs

tss-esapi/tests/integration_tests/abstraction_tests/public_tests.rs

baloo · 2024-08-04T20:38:23Z

Sorry for reviewing a WIP though I found it a little bit interesting so I couldn't help my self. Feel free to disregard anything I have commented on.

Oh, no, thanks for reviewing it!
I sent it a bit early as this is work I've been putting off for almost a year now. I'm doing it mostly to get a sense whether this is a direction the project could go or not.

ionut-arm

Thank you for bringing the patch! The overall design looks good to me.

ionut-arm · 2024-08-05T22:42:18Z

tss-esapi/src/abstraction/signatures.rs

+// Note: this does not implement `TryFrom<RsaSignature>` because `RsaSignature` does not carry the
+// information whether the signatures was generated using PKCS#1v1.5 or PSS.


The fields of RsaSignature are private, so we can extend it to capture this detail as well. It's a deviation from the TPM spec, but I don't necessarily see a problem with it. Thoughts?

cc @Superhepper

No it is not really a problem as long as it does not causes any ambiguities in the conversions between TPMS_SIGNATURE_RSA and RsaSignature.

I think it's fine like that, the comment was more for a future self why we would not have such a TryFrom

ionut-arm · 2024-08-05T22:46:56Z

tss-esapi/src/abstraction/transient/signer.rs

+use signature::{DigestSigner, Error as SigError, KeypairRef};
+
+#[derive(Debug)]
+pub struct Ecdsa<'ctx, C>


(I know this is a draft: ) Would be good to have some docs on these structs to make it clear what they're meant for.

I tried to add some, and add a code sample in the doc as well.

ionut-arm · 2024-08-05T22:58:11Z

tss-esapi/src/abstraction/transient/signer.rs

+    /// Key parameters for this curve
+    pub fn key_params<D>() -> KeyParams


I'm a bit mystified by the purpose of this function. Also by the use of "this curve" in the doc for it, given that Ecdsa is presumably not the description of a curve (?)

C describes the curve (could be NistP256, NistP384, NistP521, ...) those are all supported here. When using the signer (through the Ecdsa struct) you would specify which curve you're using.

This would pick the correct parameters to specify to the TPM when signing, the size of the object that comes back from signature, how to verify them, ...

This function just creates the TPM parameters related to this curve and the selected digest.

Sure, I think I was mostly confused by the existence of two nearly-identical methods before, and that the struct they're tacked to doesn't represent (just) a specific curve.

The key_params_default just use the "default" hashing mechanism for a given curve (P256 would use sha256, P384 would use sha384, etc).

The hashing methods needs to line up otherwise the curve has a higher "security score" than the hashing mechanism it uses and it's a waste of space.

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs

wiktor-k · 2024-08-07T13:07:32Z

tss-esapi/src/abstraction/hashing.rs

+    const TPM_DIGEST: HashingAlgorithm;
+}
+
+#[cfg(feature = "sha1")]


Hmm... how does this work if I don't see the feature declared in Cargo.toml? 🤔

yeaaah, I learned this one recently too lol.
https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies

By default, this optional dependency implicitly defines a feature that looks like this: [features] gif = ["dep:gif"]

I'm abusing that mechanism here.

I actually need to split the features in the Cargo.toml to look more like:

rustcrypto = ["ecdsa", "elliptic-curve", "signature", "x509-cert"] rustcrypto-full = ["rustcrypto", "p192", "p224", "p256", "p384", "p521", "rsa", "sha1", "sha2", "sha3", "sm2", "sm3"]

That way you can bring in rustcrypto + "p256" + "sha2" if you only care about those.

While I'm at it: I don't know how to name that feature, is rustcrypto good enough?

rustcrypto and rustcrypto-full are fine for me.

Would you be so kind to adjust all of these to use the rustcrypto-full feature name? (maybe this stuff only bothers me 😅

tss-esapi/src/abstraction/public.rs

rucoder · 2025-02-02T20:19:12Z

@baloo why EcSigner depends on TransientKeyContext? The only method is used there is sign(). Besides TransientKeyContext is limited to RSA key as a primary. it would be better IMO either

to have a constructor that that accepts Context and KeyHandle in TransientKeyContext/Builder. Currently fields are private
Or maybe turn (partially) TransientKeyContext into a trait since EcSigner uses its methods (actually only sign() so far).

I should probably explain the use case: I'm loading a key that is stored on TPM as Persistent and currently there is no way to use EcSigner with such keys. TransientTpmContext is transient for reasons but then it limits usage of EcSigner

Sure, I can implement my own signer but if we can make EcSigner more versatile it would be very cool

baloo · 2025-02-03T03:25:26Z

This is a good point. I think I like the idea of making a trait but I'm not sure how to do it yet, TransientKeyContext and Context::sign are pretty dissimilar.

baloo · 2025-02-03T07:27:40Z

I have a rough follow-up PR for the trait option: baloo#1

baloo · 2025-02-05T07:00:09Z

It was also missing the implementation for an RSA signer: baloo#2

tss-esapi/src/structures/buffers.rs

tss-esapi/Cargo.toml

ionut-arm

Looks pretty good overall!

Are you intending to add signing support for RSA too?

tss-esapi/src/abstraction/public.rs

ionut-arm · 2025-02-08T21:25:53Z

Ah, one thing that I keep forgetting - could you please document the new feature (in the README)?

Signed-off-by: Arthur Gautier <[email protected]>

wiktor-k

I think this looks good. While I'm no expert in rust crypto I'm of the opinion that this is ready to be shipped to folks to try out in the wild.

wiktor-k · 2025-02-17T09:16:05Z

tss-esapi/src/abstraction/hashing.rs

+    const TPM_DIGEST: HashingAlgorithm;
+}
+
+#[cfg(feature = "sha1")]


rustcrypto and rustcrypto-full are fine for me.

Would you be so kind to adjust all of these to use the rustcrypto-full feature name? (maybe this stuff only bothers me 😅

wiktor-k · 2025-02-17T09:17:59Z

tss-esapi/src/abstraction/public.rs

+            #[allow(unused)]
+            Public::Ecc { parameters, .. } => {
+                macro_rules! read_key {
+                    ($curve:expr, $key_type:ty) => {


Why do we need $curve if it's not used anywhere? (also the allow(unused) lint)

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 85783cc to 6525f15 Compare August 3, 2024 23:17

baloo mentioned this pull request Aug 3, 2024

WIP: examples: adds an agent storing keys on TPMs wiktor-k/ssh-agent-lib#87

Draft

1 task

baloo marked this pull request as draft August 3, 2024 23:20

baloo force-pushed the baloo/rust-crypto/signer-interface branch 2 times, most recently from 336466d to 8145f8e Compare August 4, 2024 03:35

Superhepper reviewed Aug 4, 2024

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch 6 times, most recently from df740fd to eaf82d5 Compare August 4, 2024 16:28

ionut-arm reviewed Aug 5, 2024

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch 3 times, most recently from fe52b1c to fa8ff3a Compare August 6, 2024 23:16

baloo mentioned this pull request Aug 6, 2024

signature_derive: adds support for lifetimes RustCrypto/traits#1641

Closed

baloo force-pushed the baloo/rust-crypto/signer-interface branch 4 times, most recently from 7bcbb0c to b79e193 Compare August 7, 2024 03:33

baloo commented Aug 7, 2024

View reviewed changes

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs Show resolved Hide resolved

baloo commented Aug 7, 2024

View reviewed changes

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs Show resolved Hide resolved

baloo force-pushed the baloo/rust-crypto/signer-interface branch from b79e193 to 9f760ad Compare August 7, 2024 05:29

wiktor-k reviewed Aug 7, 2024

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 9f760ad to edf67ed Compare August 7, 2024 16:37

rucoder mentioned this pull request Jan 23, 2025

v8.0.0 stabilization work #495

Open

5 tasks

baloo force-pushed the baloo/rust-crypto/signer-interface branch from edf67ed to 73e0b9c Compare January 24, 2025 20:05

baloo marked this pull request as ready for review January 24, 2025 20:05

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 01d0df7 to af146ef Compare January 27, 2025 20:50

baloo mentioned this pull request Jan 27, 2025

Bump picky- crates #560

Open

baloo force-pushed the baloo/rust-crypto/signer-interface branch from af146ef to e21adf0 Compare January 28, 2025 08:04

baloo mentioned this pull request Jan 29, 2025

support for pure-rust make credentials #563

Open

baloo force-pushed the baloo/rust-crypto/signer-interface branch from e21adf0 to ad664c0 Compare January 30, 2025 17:11

rucoder suggested changes Feb 2, 2025

View reviewed changes

tss-esapi/src/abstraction/public.rs Outdated Show resolved Hide resolved

tss-esapi/src/abstraction/public.rs Show resolved Hide resolved

baloo force-pushed the baloo/rust-crypto/signer-interface branch from ad664c0 to a699a3e Compare February 2, 2025 05:24

Superhepper reviewed Feb 8, 2025

View reviewed changes

tss-esapi/src/structures/buffers.rs Outdated Show resolved Hide resolved

Superhepper reviewed Feb 8, 2025

View reviewed changes

tss-esapi/Cargo.toml Outdated Show resolved Hide resolved

ionut-arm reviewed Feb 8, 2025

View reviewed changes

tss-esapi/src/abstraction/public.rs Show resolved Hide resolved

baloo added 2 commits February 8, 2025 21:37

Bring rustcrypto ecosystem

1eaad6b

Signed-off-by: Arthur Gautier <[email protected]>

tss-esapi: move public keys to rustcrypto ecosystem

3ab274b

Signed-off-by: Arthur Gautier <[email protected]>

baloo force-pushed the baloo/rust-crypto/signer-interface branch 2 times, most recently from 0135af5 to ff812e9 Compare February 9, 2025 06:27

baloo added 6 commits February 8, 2025 22:37

bridge digest crate with tpm digests

0eaac51

Signed-off-by: Arthur Gautier <[email protected]>

adds a AssociatedHashingAlgorithm to bridge to rustcrypto

b5e3602

Signed-off-by: Arthur Gautier <[email protected]>

Convert signature to ecdsa::Signature

719d0df

Signed-off-by: Arthur Gautier <[email protected]>

Convert signature to rsa signatures

440e4d6

Signed-off-by: Arthur Gautier <[email protected]>

adds a signature::Signer implementation for ecc keys

414ab6c

Signed-off-by: Arthur Gautier <[email protected]>

readme: document features

6f487cc

Signed-off-by: Arthur Gautier <[email protected]>

baloo force-pushed the baloo/rust-crypto/signer-interface branch from ff812e9 to a37e0ec Compare February 9, 2025 06:47

baloo added 2 commits February 8, 2025 22:52

Signer should support non-transient keys

ca00fb5

Signed-off-by: Arthur Gautier <[email protected]>

implement Signer for rsa

e8c25df

Signed-off-by: Arthur Gautier <[email protected]>

baloo force-pushed the baloo/rust-crypto/signer-interface branch from a37e0ec to e8c25df Compare February 9, 2025 06:52

wiktor-k approved these changes Feb 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds a `signature::Signer` interface #537

adds a `signature::Signer` interface #537

baloo commented Aug 3, 2024

Superhepper left a comment

baloo commented Aug 4, 2024

ionut-arm left a comment

ionut-arm Aug 5, 2024

Superhepper Aug 6, 2024

baloo Aug 6, 2024

ionut-arm Aug 5, 2024

baloo Aug 6, 2024

ionut-arm Aug 5, 2024

baloo Aug 6, 2024

ionut-arm Aug 7, 2024

baloo Jan 25, 2025

wiktor-k Aug 7, 2024

baloo Aug 7, 2024 •

edited

Loading

wiktor-k Feb 17, 2025

rucoder commented Feb 2, 2025 •

edited

Loading

baloo commented Feb 3, 2025

baloo commented Feb 3, 2025

baloo commented Feb 5, 2025

ionut-arm left a comment

ionut-arm commented Feb 8, 2025

wiktor-k left a comment

wiktor-k Feb 17, 2025

wiktor-k Feb 17, 2025

		// Note: this does not implement `TryFrom<RsaSignature>` because `RsaSignature` does not carry the
		// information whether the signatures was generated using PKCS#1v1.5 or PSS.

		/// Key parameters for this curve
		pub fn key_params<D>() -> KeyParams

adds a signature::Signer interface #537

Are you sure you want to change the base?

adds a signature::Signer interface #537

Conversation

baloo commented Aug 3, 2024

Superhepper left a comment

Choose a reason for hiding this comment

baloo commented Aug 4, 2024

ionut-arm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baloo Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rucoder commented Feb 2, 2025 • edited Loading

baloo commented Feb 3, 2025

baloo commented Feb 3, 2025

baloo commented Feb 5, 2025

ionut-arm left a comment

Choose a reason for hiding this comment

ionut-arm commented Feb 8, 2025

wiktor-k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adds a `signature::Signer` interface #537

adds a `signature::Signer` interface #537

baloo Aug 7, 2024 •

edited

Loading

rucoder commented Feb 2, 2025 •

edited

Loading