feat: implement CSS columns #304
Open
+315
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yisibl
commented
Sep 23, 2022
yisibl
commented
- Spec: https://www.w3.org/TR/css-multicol-1/#columns
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
|
@devongovett PTAL |
devongovett
reviewed
Oct 24, 2022
|
|
||
| /// A [`<length>`](https://www.w3.org/TR/css-values-4/#lengths) value | ||
| /// without a unit specified. | ||
| Unitless(CSSNumber), |
There was a problem hiding this comment.
What is this needed for? Aren't unitless lengths only allowed for zero, and compute to pixels? So why not just store as pixels?
| derive(serde::Serialize, serde::Deserialize), | ||
| serde(tag = "type", content = "value", rename_all = "kebab-case") | ||
| )] | ||
| pub enum LengthOrAuto { |
There was a problem hiding this comment.
We could probably make a generic type that allows "auto" or a type parameter. Happy to implement that separately.
| let state = input.state(); | ||
| let with_or_count = LengthOrAuto::parse(input)?; | ||
|
|
||
| if let LengthOrAuto::Length(Length::Value(LengthValue::Unitless(..))) = with_or_count { |
There was a problem hiding this comment.
Rather than parsing as a unitless length, you could instead first try parsing the column count, and if that fails, try parsing the length. When parsing shorthands where order doesn't matter, it can be useful to structure the code using a loop, trying to parse each property until values are found. There are many examples, here's one.
devongovett
force-pushed
the
master
branch
3 times, most recently
from
68a1bff
to
3930139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.