-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement allocator trait with example implementations #66
Open
pzittlau
wants to merge
20
commits into
parcio:main
Choose a base branch
from
pzittlau:allocators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to select different memory allocation strategies for segments within the database. It adds several allocator implementations and a few benchmarks to compare their performance.
Motivation:
Key changes:
Pluggable Allocators:
Allocator
trait to define the interface for segment allocators.FirstFit
: Allocates the first available block large enough.NextFit
: Starts searching for free space from the position of the last allocation.BestFitSimple
: Allocates the smallest available block that fits the request.WorstFitSimple
: Allocates the largest available block.SegmentAllocator
: The original allocator, now available as one of the choices.AllocatorType
enum to configure which allocator to use.Handler
to storeBox<dyn Allocator>
instances, allowing for dynamic selection of allocators.allocator
field toDatabaseConfiguration
to specify the desired allocation strategy.Benchmarks:
benches/allocator.rs
to evaluate the performance of different allocators.zipf
crate as a dependency for generating Zipfian distributions.Refactoring:
SegmentAllocator
implementation into its own file and made it one of the selectable options.src/allocator/
directory.Usage:
To select a specific allocator, modify the
allocator
field in yourDatabaseConfiguration
:Proposal
Lastly I propose making the
NextFit
allocator the default one for now. As per the provided benchmarks it's way faster (~100x on my machine) than the originalSegmentAllocator
.