Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update darwinia chains endpoints #169

Conversation

boundless-forest
Copy link

The Darwinia support PR merged into the XGR yesterday. colorfulnotion/xcm-global-registry#50. I noticed that this repo also relies on the XGR data, but I did not see the XGR Darwinia data imported into the registry.json under the docs. I guess it may be caused by the outdated endpoint; this PR aims to replace them with valid ones.

image

@boundless-forest boundless-forest changed the title Update darwinia chains endpoints fix: update darwinia chains endpoints Nov 5, 2024
@marshacb
Copy link
Collaborator

marshacb commented Nov 5, 2024

The Darwinia support PR merged into the XGR yesterday. colorfulnotion/xcm-global-registry#50. I noticed that this repo also relies on the XGR data, but I did not see the XGR Darwinia data imported into the registry.json under the docs. I guess it may be caused by the outdated endpoint; this PR aims to replace them with valid ones.

image

Hi @boundless-forest,

Thanks for the PR! The asset transfer api registry updates once a day and may have missed the update from the global xcm registry at the time of its last update. The list edited in this PR is used to filter bad rpcs that cause the registry build to fail so adding valid rpcs isnt intended. As long as the relevant rpc endpoints are in PolkadotJS Apps then the data required from those rpcs will be added.

I made a PR to update the registry and it includes the assets recently added to Darwinia.

@marshacb marshacb closed this Nov 5, 2024
@boundless-forest boundless-forest deleted the bear-update-darwinia branch November 5, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants