Pallet referenda tracks for dynamic governance #2448
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
This PR adds missing `environment: release` parameter to the `rc-automation ` GHA
Using an iterator instead of a static slice allows for more flexible implementations of `TracksInfo` that can use the chain storage without compromising a lot on the performance/memory penalty if we were to return an owned `Vec` instead. NOTE: This feature will benefit from the soon to be released return_position_impl_trait_in_trait(rust-lang/rust#115822) to not require the `TracksIter` associated type and from a bugfix in the compiler(rust-lang/rust#116662) to declare the DEFAULT_MAX_TRACK_NAME_LEN generic constant in the `TracksInfo` trait.
pandres95
force-pushed
the
virto-pallet-referenda-tracks
branch
from
c7ed574 to
f144d64
Compare
Implement TracksInfo for referenda-tracks
fix(pallet-referenda): impl Debug + PartialEq on TrackInfo chore(impl_tracks_info): split codebase chore(referenda-tracks): add test suite
olanod
force-pushed
the
virto-pallet-referenda-tracks
branch
from
f144d64 to
c280ba1
Compare
|
User @darkforest0202, please sign the CLA here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Based on #2072 this pallet is coupled with pallet-referenda to implement
TracksInfoso that track information and mapping origins is dynamic and can be edited via extrinsics.