feat(collator) add export pov on slot base collator #7585
+136
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
reviewed
Feb 18, 2025
| @@ -140,6 +146,28 @@ async fn handle_collation_message<Block: BlockT>( | |||
| ); | |||
|
|
|||
| if let MaybeCompressedPoV::Compressed(ref pov) = collation.proof_of_validity { | |||
|
|
|||
| if let Ok(relay_parent_header) = relay_client.header(BlockId::Hash(relay_parent)).await { | |||
There was a problem hiding this comment.
Please adjust this a bit:
- You can pattern match directly for
Ok(Some(relay_parent_header)) - Check for
export_povas outermost check, otherwise we always fetch therelay_parent_headerhere even though we don't need to (most of the time,export_povwill be false, it is rarely used).
bkchr
reviewed
Feb 18, 2025
| @@ -74,7 +74,7 @@ use crate::{collator as collator_util, LOG_TARGET}; | |||
| /// | |||
| /// The `parent_header`, `relay_parent_storage_root` and `relay_parent_number` will also be | |||
| /// stored in the file alongside the `pov`. This enables stateless validation of the `pov`. | |||
| fn export_pov_to_path<Block: BlockT>( | |||
| pub fn export_pov_to_path<Block: BlockT>( | |||
There was a problem hiding this comment.
Please just move the method to the lib.rs of this crate.
skunert
reviewed
Feb 19, 2025
| @@ -68,6 +71,7 @@ pub async fn run_collation_task<Block, RClient, CS>( | |||
| mut collator_receiver, | |||
| mut block_import_handle, | |||
| }: Params<Block, RClient, CS>, | |||
| export_pov: Option<PathBuf> | |||
There was a problem hiding this comment.
Please make eport_pov part of Params
Comment on lines
175
to
+177
|
|
||
| let collation_task_fut = run_collation_task::<Block, _, _>(collator_task_params); | ||
| // check here for export | ||
|
|
There was a problem hiding this comment.
Suggested change
| let collation_task_fut = run_collation_task::<Block, _, _>(collator_task_params); | |
| // check here for export |
| /// | ||
| /// The `parent_header`, `relay_parent_storage_root` and `relay_parent_number` will also be | ||
| /// stored in the file alongside the `pov`. This enables stateless validation of the `pov`. | ||
| pub fn export_pov_to_path<Block: BlockT>( |
There was a problem hiding this comment.
Suggested change
| pub fn export_pov_to_path<Block: BlockT>( | |
| pub(crate) fn export_pov_to_path<Block: BlockT>( |
| slot_based::run::<Block, AuthorityPair, _, _, _, _, _, _, _, _, _>(params); | ||
| let params_with_export = SlotBasedParamsWithExport { | ||
| params, | ||
| None |
There was a problem hiding this comment.
This does not compile because you need to provide a name for this struct field. But check the other comment, this should just be Params.
| - name: cumulus-test-service | ||
| bump: patch | ||
| - name: cumulus-client-consensus-aura | ||
| bump: patch |
There was a problem hiding this comment.
Chaging the parameters is a major change, since the params are public.
Suggested change
| bump: patch | |
| bump: major |
| title: 'Add export PoV on slot base collator' | ||
| doc: | ||
| - audience: [Node Dev, Node Operator] | ||
| description: Add functionality to export Proof of Validity (PoV) based on collator slots. |
There was a problem hiding this comment.
Suggested change
| description: Add functionality to export Proof of Validity (PoV) based on collator slots. | |
| description: Add functionality to export the Proof of Validity (PoV) when the slot-based collator is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7573
@skunert @bkchr