Prevent default event action #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never merged, right? |
| @@ -132,7 +132,9 @@ const _onBeforeInput = shortcutsOfWindow => (e, input) => { | |||
| for (const {eventStamp, callback} of shortcutsOfWindow) { | |||
| if (equals(eventStamp, event)) { | |||
| debug(`eventStamp: ${eventStamp} match`); | |||
| callback(); | |||
| if (callback()) { | |||
There was a problem hiding this comment.
Curious why not pass e to the callback and let the downstream code preventDefault? That feels more "normal" like working with typical event handler callbacks.
There was a problem hiding this comment.
I created this from our use case and we always return true to prevent Electron from handling events (c&p from our fork). I also prefer the cleaner control flow and don't think it's necessary to pass the whole event, but on the other side, others may require the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to prevent the default action when the callback returns
true. E.g:fixes #69