Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default event action #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent default event action #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ const _onBeforeInput = shortcutsOfWindow => (e, input) => {
for (const {eventStamp, callback} of shortcutsOfWindow) {
if (equals(eventStamp, event)) {
debug(`eventStamp: ${eventStamp} match`);
callback();
if (callback()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why not pass e to the callback and let the downstream code preventDefault? That feels more "normal" like working with typical event handler callbacks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this from our use case and we always return true to prevent Electron from handling events (c&p from our fork). I also prefer the cleaner control flow and don't think it's necessary to pass the whole event, but on the other side, others may require the event.

e.preventDefault();
}

return;
}
Expand Down