Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to AWS S3 SDK v3 #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmendoza
Copy link

No description provided.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 23, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@fmendoza fmendoza changed the title migrate to aws skd v3 fix: migrate to aws sdk v3 Apr 23, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: migrate to aws sdk v3 fix: Migrate to aws sdk v3 Apr 23, 2023
@@ -25,7 +25,7 @@
},
"homepage": "https://github.com/parse-community/parse-server-s3-adapter#readme",
"dependencies": {
"aws-sdk": "2.1362.0"
"@aws-sdk/client-s3": "^3.317.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to a fixed version?

@mtrezza mtrezza changed the title fix: Migrate to aws sdk v3 feat: Upgarde to use AWS S3 SDK v3 Apr 29, 2023
@mtrezza mtrezza changed the title feat: Upgarde to use AWS S3 SDK v3 feat: Upgrade to AWS S3 SDK v3 Apr 29, 2023
@mtrezza
Copy link
Member

mtrezza commented Apr 29, 2023

Could you take a look at the failing CI?
https://github.com/parse-community/parse-server-s3-adapter/actions/runs/4779434092/jobs/8626774080?pr=191

Would this be a breaking change? I assume not, because the S3 client is not directly exposed for developers, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants